Repository navigation
fix(anthropic): Preserve cached _iterator property - #8163
Conversation
8e1712b to
054e95c
Compare
6812235 to
a215e50
Compare
Coverage Results 📊✅ 136864 passed | ⏭️ 7456 skipped | Total: 144320 | Pass Rate: 94.83% | Execution Time: 450m 47s All tests are passing successfully. ✅ Patch coverage is 93.33% (28 of 30 changed executable lines covered; target 80%). Changed files with executable lines (1)
Generated by Coverage Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a215e50. Configure here.
| result._iterator = _wrap_synchronous_message_iterator( # type: ignore[misc] | ||
| cast("_PatchedRawMessageStream", result), | ||
| result._iterator, | ||
| ) |
There was a problem hiding this comment.
Version gate skips iterator wrapping
High Severity
The global _iterator patch is applied only when _iterator is a functools.cached_property, but per-instance wrapping is skipped for every Anthropic version >= 1.14. Those two checks are not complementary, so a 1.14+ install whose _iterator is still an eager attribute (or a different descriptor than functools.cached_property) gets neither wrap. Streaming spans then miss accumulated output data, and if the caller never calls close(), the span never finishes.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit a215e50. Configure here.
There was a problem hiding this comment.
If they ever change it from being a cached property we want to degrade gracefully (and that's more important than finishing the span).
I know this looks weird but I use the version gate for the old behavior because we know that works without checking the type of _iterator and check that _iterator is a cached property otherwise to ensure forwards compatibility.
a215e50 to
8606111
Compare
…rializable Image instances. See typesafe-ai/typesafe-sdk-python@f36e685. Record inline messages as their reference and do not raise on unserializable input.
…getsentry/sentry-python into webb/anthropic/preserve-cached-property
Description
See anthropics/anthropic-sdk-python@abd6424.
Since
_iteratorwas changed from a member initialized in__init__to a cached property, the SDK can and should use a global patch so we don't destroy the laziness of accessing the cached property.A global patch is also more maintainable because we don't have to worry about double patching, etc ...
I've changed the generic parameter for
StreamandAsyncStreamtoAny, since users can technically provide a custom parser.Also fixed the following mypy errors when upgrading
anthropicinuv.lock:Issues
Closes #8166
Reminders
uv run ruff.feat:,fix:,ref:,meta:)